Support external Bitcoin nodes in hashi-localnet CLI#365
Open
0xsiddharthks wants to merge 3 commits intomainfrom
Open
Support external Bitcoin nodes in hashi-localnet CLI#3650xsiddharthks wants to merge 3 commits intomainfrom
0xsiddharthks wants to merge 3 commits intomainfrom
Conversation
Contributor
|
Wonder if it would be possible to support external Sui network (devnet / testnet) too? |
0xsiddharthks
force-pushed
the
siddharth/e2e-test-signet
branch
2 times, most recently
from
223c348 to
355d8e5
Compare
Contributor
Author
|
@Bridgerz I have created a test implementation ( #407 ) which patches this function right before publishing the contract artifacts. but tbh it doesn't feel good. Not sure if we should try to do it. |
0xsiddharthks
force-pushed
the
siddharth/e2e-test-signet
branch
from
56da15b to
11d4b50
Compare
Contributor
Author
|
also wrapped all synchronous calls from corepc with |
0xsiddharthks
force-pushed
the
siddharth/e2e-test-signet
branch
from
11d4b50 to
1fd688e
Compare
Add --bitcoin-network flag to `hashi-localnet start` to connect to external Bitcoin nodes (signet, testnet4) instead of spawning a local regtest instance.
Qualify the rustdoc link to fix `make doc` CI failure.
The corepc-client uses the client-sync feature, so all Bitcoin Core RPC calls are blocking HTTP requests. When called from async functions they block the tokio worker thread. - Wrap Client in Arc<Client> in BitcoinNodeHandle and ExternalBitcoinNode so it can be cloned into spawn_blocking closures - Convert send_to_address, generate_blocks, get_new_address, get_balance, get_block_count to async with spawn_blocking - Wrap RPC calls in cmd_deposit poll loops with spawn_blocking - Persist btc_wallet in LocalnetState so deposit uses the correct wallet on non-regtest networks - Add crate-level spawn_blocking helper (same pattern as mpc_except_signing.rs)
0xsiddharthks
force-pushed
the
siddharth/e2e-test-signet
branch
from
1fd688e to
6a287a8
Compare
bmwill
reviewed
Apr 10, 2026
Comment on lines
+25
to
+38
| /// Trait for Bitcoin node connectivity used by the hashi network builder. | ||
| pub trait BitcoinNodeInfo { | ||
| fn rpc_url(&self) -> &str; | ||
| fn p2p_address(&self) -> String; | ||
| } | ||
|
|
||
| impl BitcoinNodeInfo for crate::BitcoinNodeHandle { | ||
| fn rpc_url(&self) -> &str { | ||
| self.rpc_url() | ||
| } | ||
| fn p2p_address(&self) -> String { | ||
| self.p2p_address() | ||
| } | ||
| } |
bmwill
reviewed
Apr 10, 2026
| dir: &Path, | ||
| sui: &SuiNetworkHandle, | ||
| bitcoin: &BitcoinNodeHandle, | ||
| bitcoin: &impl BitcoinNodeInfo, |
Contributor
There was a problem hiding this comment.
would it maybe be better to just pass in the rpc and p2p values directly vs needing to go through a trait?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the hashi-localnet CLI to support running against external Bitcoin nodes (signet, testnet4), instead of only spawning a local regtest instance.
Usage